Fix CI linting failures by adding eslint peer dependency #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AAllport <3750120+AAllport@users.noreply.github.com>
Co-authored-by: AAllport <3750120+AAllport@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update monorepo for 2026 dependency baselines
Fix CI linting failures by adding eslint peer dependency
Feb 1, 2026
There was a problem hiding this comment.
Pull request overview
Fixes CI lint failures by ensuring eslint is available where @nuxt/eslint is used, using pnpm’s workspace catalog for consistent versioning.
Changes:
- Added
eslint(^9.39.2) to the pnpm workspace catalog and updated packages to useeslint: "catalog:". - Updated
pnpm-lock.yamlto reflect the new catalog entry and importer specifiers. - Applied small lint/format fixes in
DeckIconPicker.client.vueandvitest.config.ts.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds eslint to the workspace catalog for centralized version management. |
| pnpm-lock.yaml | Captures the new catalog entry and updates importer specifiers to catalog:. |
| packages/localdeck-configurator/vitest.config.ts | Lint formatting fix (semicolons / whitespace). |
| packages/localdeck-configurator/package.json | Adds eslint as a dev dependency via catalog:. |
| packages/localdeck-components/src/components/DeckIconPicker.client.vue | Removes stray blank line causing lint failure. |
| packages/localdeck-components/package.json | Adds eslint as a dev dependency via catalog:. |
| packages/localdeck-codegen/package.json | Switches eslint from a pinned version to catalog:. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI linting failed because
eslintwas not installed as a peer dependency for@nuxt/eslintin the components and configurator packages.Changes
^9.39.2) for centralized version managementeslint: "catalog:"instead of direct version pinsDeckIconPicker.client.vueandvitest.config.ts(extra blank lines, missing semicolons)The catalog approach ensures version consistency across the monorepo and simplifies future updates. Using
^instead of~aligns with the existing catalog pattern (nuxt, typescript).💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.